HDDS-12002. Move up out() and err() to AbstractSubcommand #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Jan 12, 2025
...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneTenantShell.java
Outdated
Show resolved
Hide resolved
...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneTenantShell.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/ValueSchema.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Thanks @chiacyu for updating the patch. There is an unused import, otherwise LGTM.
...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneTenantShell.java
Show resolved
Hide resolved
adoroszlai
approved these changes
Jan 13, 2025
|
Thanks @chiacyu for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
out()anderr()methods are defined in few different subcommands, it would be better to move it up toAbstractSubcommandto reduce code duplication. Please take a look, thanks.What is the link to the Apache JIRA
HDDS-12002
How was this patch tested?
It can test by integration tests.