HDDS-12348. Reuse TestDataUtil.createKey method
#7971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Feb 26, 2025
| private void createKey(OzoneBucket ozoneBucket, String key, int length, | ||
| byte[] input) | ||
| private void createAndAssertKey(OzoneBucket ozoneBucket, String key, int length, | ||
| byte[] input) |
There was a problem hiding this comment.
nit: Please do not format method signature like this. Whenever visibility / return type / method name / other modifiers are changed, we would have to reindent parameters.
...-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStoreWithFSO.java
Outdated
Show resolved
Hide resolved
...-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStoreWithFSO.java
Outdated
Show resolved
Hide resolved
| ozoneOutputStream.write(input, 0, 10); | ||
| ozoneOutputStream.close(); | ||
|
|
||
| createKey(ozoneBucket, key, new String(input, UTF_8)); |
There was a problem hiding this comment.
Sorry I haven't noticed that we write byte[] but createKey accepts String.
Instead of wrapping in new String in each call (here and the other test classes), let's create a new version of createKey in TestDataUtil that accepts byte[].
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestBucketOwner.java
Outdated
Show resolved
Hide resolved
...-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStoreWithFSO.java
Outdated
Show resolved
Hide resolved
...-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestObjectStoreWithFSO.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestListKeys.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestListKeysWithFSO.java
Outdated
Show resolved
Hide resolved
adoroszlai
added
test
code-cleanup
adoroszlai
reviewed
Feb 28, 2025
There was a problem hiding this comment.
Thanks @chiacyu for updating the patch. I think it's almost good to go.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestDataUtil.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
TestDataUtil.createKeycan be reused in many places to reduce the code redundancy, please take a look, thanks!What is the link to the Apache JIRA
HDDS-12348
How was this patch tested?
It can test by CI.