Add verification guide for release #98
Open
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
approved these changes
Feb 2, 2025
Co-authored-by: Gang Wu <[email protected]>
Fokko
reviewed
Feb 3, 2025
| The command will output a summary, the list of files with their licenses and any file that does not contain a valid license header. | ||
|
|
||
| ``` | ||
| java -jar apache-rat-0.16.1/apache-rat-0.16.1.jar -a -d apache-parquet-1.15.0.tar.gz -e "\w+.avsc$|\w+\-2.parquet$|.gitignore|PULL_REQUEST_TEMPLATE.md" |
There was a problem hiding this comment.
We should probably add the excluded files to a .rat-excludes file: https://github.com/apache/iceberg/blob/main/dev/.rat-excludes
There was a problem hiding this comment.
Yes, I was having some issues integrating the .rat-excludes file with the rat-plugin on my original PR:
https://github.com/apache/parquet-java/pull/3101/files#r1876006229
We might want to do that once we update rat-plugin to use a single source for rat-excludes instead of listing exclusions on the pom.xml?
gszadovszky
approved these changes
Feb 4, 2025
|
Should we merge this? Do you have any concern? @Fokko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There is currently no guide on how to verify. Having a guide will encourage people to verify the release.
This guide should also be linked on the Voting thread.
What changes are included in this PR?
Added documentation about how to verify.
Are these changes tested?
I've validated all steps localy
Closes apache/parquet-java#3091
(Maybe someone with permissions can move that issue to this repo :) )