hikari 6 #238
Closed
hikari 6 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
approved these changes
Oct 7, 2024
| @@ -34,6 +34,7 @@ object Dependencies { | |||
| "org.apache.pekko" %% "pekko-persistence-query" % PekkoVersion, | |||
| "com.typesafe.slick" %% "slick" % SlickVersion, | |||
| "com.typesafe.slick" %% "slick-hikaricp" % SlickVersion, | |||
| "com.zaxxer" % "HikariCP" % "6.0.0", | |||
There was a problem hiding this comment.
maybe add a comment that we can get this transitively again once we unpin slick?
|
Closing - looks like Hikari 4 is the last to support Java 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that we are pinned to an old version of Slick - we are stuck with its old version of hikari
Let's explicitly use a newer Hikari version. We are missing out on bug fixes.
https://github.com/brettwooldridge/HikariCP/blob/dev/CHANGES