-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PHOENIX-7502 :- Decouple principal from HAGroupInfo (#2053)
Co-authored-by: lokesh-khurana <[email protected]>
- Loading branch information
Showing
21 changed files
with
833 additions
and
160 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/FailoverPhoenixContext.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.phoenix.jdbc; | ||
|
|
||
| import java.util.Properties; | ||
|
|
||
| /** | ||
| * FailoverPhoenixContext holds the properties and HAGroup Info for a failover phoenix connection. | ||
| */ | ||
| public class FailoverPhoenixContext { | ||
|
|
||
| private final Properties properties; | ||
| private final HighAvailabilityGroup haGroup; | ||
| private final HAURLInfo haurlInfo; | ||
|
|
||
| FailoverPhoenixContext(Properties properties, HighAvailabilityGroup haGroup, | ||
| HAURLInfo haurlInfo) { | ||
| this.properties = properties; | ||
| this.haGroup = haGroup; | ||
| this.haurlInfo = haurlInfo; | ||
| } | ||
|
|
||
| public Properties getProperties() { | ||
| return properties; | ||
| } | ||
|
|
||
| public HighAvailabilityGroup getHAGroup() { | ||
| return haGroup; | ||
| } | ||
|
|
||
| public HAURLInfo getHAURLInfo() { | ||
| return haurlInfo; | ||
| } | ||
| } |
104 changes: 104 additions & 0 deletions
104
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAURLInfo.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.phoenix.jdbc; | ||
|
|
||
|
|
||
| import org.apache.commons.lang3.builder.EqualsBuilder; | ||
| import org.apache.commons.lang3.builder.HashCodeBuilder; | ||
| import org.apache.phoenix.thirdparty.com.google.common.annotations.VisibleForTesting; | ||
| import org.apache.phoenix.thirdparty.com.google.common.base.Preconditions; | ||
|
|
||
| /** | ||
| * An HAURLInfo contains information of an HA Url with respect of HA Group Name. | ||
| * <p> | ||
| * It is constructed based on client input, including the JDBC connection string and properties. | ||
| * Objects of this class are used to get appropriate principal and additional JDBC parameters. | ||
| * <p> | ||
| * This class is immutable. | ||
| */ | ||
|
|
||
| @VisibleForTesting | ||
| public class HAURLInfo { | ||
| private final String name; | ||
| private final String principal; | ||
| private final String additionalJDBCParams; | ||
|
|
||
| HAURLInfo(String name, String principal, String additionalJDBCParams) { | ||
| Preconditions.checkNotNull(name); | ||
| this.name = name; | ||
| this.principal = principal; | ||
| this.additionalJDBCParams = additionalJDBCParams; | ||
| } | ||
|
|
||
| HAURLInfo(String name, String principal) { | ||
| this(name, principal, null); | ||
| } | ||
|
|
||
| HAURLInfo(String name) { | ||
| this(name, null, null); | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public String getPrincipal() { | ||
| return principal; | ||
| } | ||
|
|
||
| public String getAdditionalJDBCParams() { | ||
| return additionalJDBCParams; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| if (principal != null) { | ||
| return String.format("%s[%s]", name, principal); | ||
| } | ||
| return name; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object other) { | ||
| if (other == null) { | ||
| return false; | ||
| } | ||
| if (other == this) { | ||
| return true; | ||
| } | ||
| if (other.getClass() != getClass()) { | ||
| return false; | ||
| } | ||
| HAURLInfo otherInfo = (HAURLInfo) other; | ||
| return new EqualsBuilder() | ||
| .append(name, otherInfo.name) | ||
| .append(principal, otherInfo.principal) | ||
| .isEquals(); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| if (principal != null) { | ||
| return new HashCodeBuilder(7, 47) | ||
| .append(name) | ||
| .append(principal).hashCode(); | ||
| } | ||
| return new HashCodeBuilder(7, 47).append(name).hashCode(); | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.