Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6851 Add spotless to format code #1548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mnpoonia
Copy link
Contributor

@mnpoonia mnpoonia commented Jan 2, 2023

No description provided.

@mnpoonia
Copy link
Contributor Author

mnpoonia commented Jan 3, 2023

Yetus checks seems to fail for a comment which is a url. I am hoping that is fine. @virajjasani

@virajjasani
Copy link
Contributor

HBase also did something like one time format of the entire codebase. Ever since then, every PR merge follows spotless way of format to maintain same format. Do we want to start using spotless after this commit (without touching current codebase)?

FYI @stoty you might also have some thoughts.

@mnpoonia
Copy link
Contributor Author

mnpoonia commented Jan 4, 2023

I am planning to create a subtask to do a one time formatting for entire codebase. @virajjasani

@stoty
Copy link
Contributor

stoty commented Jan 16, 2023

If we do this, then IMO the code cleanup and the check should be committed together.

One hand this would be a major PITA, for backports, etc.
On the other hand the current code looks horrible.

I don't have a strong opinion either way.
I think that this should be discussed on the dev@ list, as this is a very intrusive change.

@lfrancke
Copy link
Member

There is a new attempt here: #1995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants