Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-7505 HBase 3 compatibility changes: Update zookeeper handling #2056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szucsvillo
Copy link
Contributor

No description provided.

Co-authored-by: Istvan Toth <[email protected]>
@szucsvillo szucsvillo marked this pull request as draft January 14, 2025 08:54
@szucsvillo szucsvillo marked this pull request as ready for review January 15, 2025 15:08
@@ -58,6 +59,7 @@ public static synchronized void setUp() throws Exception {
conf = hbaseTestUtil.getConfiguration();
setUpConfigForMiniCluster(conf);
conf.set(HConstants.ZOOKEEPER_ZNODE_PARENT, "/hbase-test");
conf.set("hbase.client.registry.impl", ZKConnectionInfo.ZK_REGISTRY_NAME);
Copy link
Contributor

@stoty stoty Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to support back HBase version from 2.4.0, and that one already has CLIENT_CONNECTION_REGISTRY_IMPL_CONF_KEY, so better use that.

@@ -71,6 +72,8 @@ public void testUpdateCacheFrequencyWithAddAndDropTable() throws Exception {
longRunningProps.put(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB,
QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);
longRunningProps.put(QueryServices.DROP_METADATA_ATTRIB, Boolean.TRUE.toString());
longRunningProps.put("hbase.client.registry.impl", ZKConnectionInfo.ZK_REGISTRY_NAME);
Copy link
Contributor

@stoty stoty Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same apples to all "hbase.client.registry.impl" strings, we can use HConstants instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants