Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-7495 :- Support for HBase Registry Implementations in Pheonix HA Connections #2074

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

PHOENIX-7495 :- Support for HBase Registry Implementations in Pheonix HA Connections #2074

wants to merge 5 commits into from
+2,130 −824

Conversation

lokiore
Copy link
Contributor

@lokiore lokiore commented Feb 10, 2025

No description provided.

@lokiore lokiore requested review from jpisaac and kadirozde February 11, 2025 17:38
dbwong
dbwong reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@dbwong dbwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment, these HA IT tests are extremely heavy... I'd recommend we don't parameterize all these tests.

@lokiore
Copy link
Contributor Author

lokiore commented Feb 11, 2025

General comment, these HA IT tests are extremely heavy... I'd recommend we don't parameterize all these tests.

@dbwong yes I was checking how much time it will increase, which seems to be a lot. Will add couple of separate classes with cherry picked tests ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwong dbwong dbwong left review comments

@jpisaac jpisaac Awaiting requested review from jpisaac

@kadirozde kadirozde Awaiting requested review from kadirozde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lokiore @dbwong