PHOENIX-7527 NPE thrown when extract table schema using sqlline. #2079
Conversation
chaijunjie0101
changed the title
chaijunjie0101
changed the title
chaijunjie0101
force-pushed
the
PHOENIX-7527
branch
2 times, most recently
from
2e2543e to
1c067d6
Compare
chaijunjie0101
force-pushed
the
PHOENIX-7527
branch
from
1c067d6 to
884913d
Compare
| @@ -2614,6 +2614,15 @@ public QueryPlan getQueryPlan() { | |||
| @Override | |||
| public ResultSet getResultSet() throws SQLException { | |||
| ResultSet rs = getLastResultSet(); | |||
| if (!isClosed && rs == null && lastQueryPlan != null) { | |||
There was a problem hiding this comment.
This feels like this a band-aid to cover for an error in the resultset logic.
Can we fix the logic instad so that this is hacky solution is not needed ?
There was a problem hiding this comment.
This feels like this a band-aid to cover for an error in the resultset logic.
Can we fix the logic instad so that this is hacky solution is not needed ?
yeah...But if we set the resultSet on this statement...may break the old logic...not sure why set ResultSet in the QueryPlan's context? it is differnt with JDBC statement logic...we need be careful to change some old logic even it is wrong...need keep maintain compatibility.
I will check again if we could fix the wrong resultset logic, or if you want to fix it, you also could do it~
Thanks for reviewing~
No description provided.