Speed up BinaryOperatorTransformFunction evaluation to use PredicateEvaluator #14619
+556
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
from
377045c to
eaf6a9d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14619 +/- ##
============================================
+ Coverage 61.75% 63.68% +1.93%
- Complexity 207 1482 +1275
============================================
Files 2436 2716 +280
Lines 133233 152471 +19238
Branches 20636 23591 +2955
============================================
+ Hits 82274 97097 +14823
- Misses 44911 48045 +3134
- Partials 6048 7329 +1281
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
4 times, most recently
from
9778fbb to
5164df3
Compare
.../java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
3 times, most recently
from
fc21c88 to
ff991bf
Compare
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
4 times, most recently
from
9e0a4d7 to
c2c2707
Compare
xiangfu0
changed the title
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
from
c2c2707 to
f11f540
Compare
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
2 times, most recently
from
105728e to
cc9534a
Compare
It's already tested by BinaryOperatorTransformFunctionTest |
xiangfu0
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
from
cc9534a to
5907925
Compare
Jackie-Jiang
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
from
5850d63 to
969935e
Compare
Jackie-Jiang
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
from
969935e to
4e79a0a
Compare
Jackie-Jiang
force-pushed
the
BinaryOperatorTransformFunction-optimization
branch
from
4e79a0a to
e4c33b9
Compare
Jackie-Jiang
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BinaryOperatorTransformFunction, we don't need to read the values then compare but use dictionary.
Further optimization could be using predicate evaluator.