get online brokers in pinot spark connector #14802
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14802 +/- ##
============================================
+ Coverage 61.75% 63.83% +2.07%
- Complexity 207 1611 +1404
============================================
Files 2436 2704 +268
Lines 133233 150910 +17677
Branches 20636 23291 +2655
============================================
+ Hits 82274 96327 +14053
- Misses 44911 47368 +2457
- Partials 6048 7215 +1167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
cc: @ankitsultana |
| @@ -33,7 +33,7 @@ import scala.util.{Failure, Success, Try} | |||
| */ | |||
| private[pinot] object PinotClusterClient extends Logging { | |||
| private val TABLE_SCHEMA_TEMPLATE = "http://%s/tables/%s/schema" | |||
| private val TABLE_BROKER_INSTANCES_TEMPLATE = "http://%s/v2/brokers/tables/%s" | |||
| private val TABLE_BROKER_INSTANCES_TEMPLATE = "http://%s/v2/brokers/tables/%s?state=%s" | |||
There was a problem hiding this comment.
can you instead use the livebrokers API? We have used it at scale in the past so there are no concerns with whether it works or not.
rohityadav1993
force-pushed
the
ps-fix
branch
from
c9dfa73 to
72eb48a
Compare
rohityadav1993
force-pushed
the
ps-fix
branch
from
72eb48a to
ec949a9
Compare
| @@ -33,7 +33,7 @@ import scala.util.{Failure, Success, Try} | |||
| */ | |||
| private[pinot] object PinotClusterClient extends Logging { | |||
| private val TABLE_SCHEMA_TEMPLATE = "http://%s/tables/%s/schema" | |||
| private val TABLE_BROKER_INSTANCES_TEMPLATE = "http://%s/v2/brokers/tables/%s" | |||
| private val LIVE_BROKERS_TEMPLATE = "http://%s/tables/livebrokers?tables=%s" | |||
There was a problem hiding this comment.
usage is incorrect. table goes in the path
There was a problem hiding this comment.
The API with path param was deprecated in favour of this one in #12201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfixpinot-spark-connector when reading from Pinot table fetches the broker urls from controller using
http://%s/v2/brokers/tables/%s.This returns all brokers including dead broker instances as well which can cause the spark job to fail.
This PR updates the controller API uri in request to also filter on state="OFFLINE" so that only a valid list of brokers is fetched.