Include information on whether a query is using SSQE or MSQE in QueryLogger #14938
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
added
enhancement
observability
multi-stage
yashmayya
commented
Jan 29, 2025
| @@ -255,6 +257,12 @@ void doFormat(StringBuilder builder, QueryLogger logger, QueryLogParams params) | |||
| builder.append(CommonConstants.UNKNOWN); | |||
| } | |||
| } | |||
| }, | |||
| IS_MULTI_STAGE_QUERY_ENGINE("isMultiStageQueryEngine") { | |||
There was a problem hiding this comment.
Alternatively, we could call this queryEngine with possible options being singleStage / multiStage so that it is open to future extensions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14938 +/- ##
============================================
+ Coverage 61.75% 63.70% +1.94%
- Complexity 207 1472 +1265
============================================
Files 2436 2710 +274
Lines 133233 151931 +18698
Branches 20636 23462 +2826
============================================
+ Hits 82274 96782 +14508
- Misses 44911 47881 +2970
- Partials 6048 7268 +1220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Jan 29, 2025
pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java
Outdated
Show resolved
Hide resolved
gortiz
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serverStatsis empty (MSQE) or not (SSQE).