Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when colocated join is requested but workermanager is disabled #14947

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gortiz
Copy link
Contributor

@gortiz gortiz commented Jan 30, 2025

Simple change to include the property that needs to be changed

@gortiz gortiz requested a review from yashmayya January 30, 2025 11:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.68%. Comparing base (59551e4) to head (4e7a58f).
Report is 1693 commits behind head on master.

Files with missing lines Patch % Lines
.../java/org/apache/pinot/query/QueryEnvironment.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14947      +/-   ##
============================================
+ Coverage     61.75%   63.68%   +1.92%     
- Complexity      207     1482    +1275     
============================================
  Files          2436     2727     +291     
  Lines        133233   152457   +19224     
  Branches      20636    23565    +2929     
============================================
+ Hits          82274    97086   +14812     
- Misses        44911    48057    +3146     
- Partials       6048     7314    +1266     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.65% <0.00%> (+1.94%) ⬆️
java-21 63.55% <0.00%> (+1.92%) ⬆️
skip-bytebuffers-false 63.66% <0.00%> (+1.91%) ⬆️
skip-bytebuffers-true 63.55% <0.00%> (+35.82%) ⬆️
temurin 63.68% <0.00%> (+1.92%) ⬆️
unittests 63.67% <0.00%> (+1.92%) ⬆️
unittests1 56.22% <0.00%> (+9.33%) ⬆️
unittests2 34.00% <0.00%> (+6.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants