Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in controller #14951

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gortiz
Copy link
Contributor

@gortiz gortiz commented Jan 30, 2025

This PR is trying to fix the two first controller errors listed in #14950:

  • On errors, Pinot controller query endpoints inconsistently return broker-like JSON error payloads (if the error is detected by the broker) or plain text (if the controller itself detected the error)
  • The Pinot controller detected errors that were not logged.

It also optimizes the way controllers pipeline query results from brokers. The current version should be faster (see https://schoeffm.github.io/posts/response-streaming-between-jaxrs-and-webcomponents-part1/) and, most importantly, zero-copy (while previous code copied the query response on the heap not once but twice!!!)

Introduce a new PinotRuntimeException and modify other SPI exceptions to extend from it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant