FIX: Modifying the helm chart used for Pinot Quickstart #14952
+0
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bugfix fixes the issue with apache#14696 According to the documentation for installation of Pinot in k8s using helm charts (https://docs.pinot.apache.org/basics/getting-started/kubernetes-quickstart#start-pinot-with-helm), the namespace is created manually. This creates a conflict with the namespace.yaml present in the templates, leading to failure of deployment. Signed-off-by: Subhashini Narayanaswamy <[email protected]>
|
@abhioncbr Can you help review this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14952 +/- ##
============================================
+ Coverage 61.75% 63.70% +1.95%
- Complexity 207 1472 +1265
============================================
Files 2436 2710 +274
Lines 133233 151924 +18691
Branches 20636 23463 +2827
============================================
+ Hits 82274 96783 +14509
- Misses 44911 47871 +2960
- Partials 6048 7270 +1222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix fixes the issue with #14696
The following error is encountered when trying to deploy Apache Pinot on k8s clusters using Helm chart with the instructions mentioned here:
Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: Namespace "pinot-quickstart" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "[app.kubernetes.io/managed-by](http://app.kubernetes.io/managed-by)": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "pinot"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "pinot-quickstart"The fix here removes the additional
namespace.yamlpresent in the templates, which is redundant when the user does the namespace creation manually, as provided in the quickstart documentation.bugfixkubernetesThe program was tested solely for our own use cases, which might differ from yours.
Signed-off-by: Subhashini Narayanaswamy [email protected] on behalf of Mercedes-Benz Research and Development India
https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md