Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize lookup table in join operator #14972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

Optimize lookup table (right table) in HashJoinOperator:

  • Use primitive key map for single join key of type INT, LONG, FLOAT, DOUBLE
  • Specialize unique keys case to avoid creating List

@Jackie-Jiang Jackie-Jiang added query performance multi-stage Related to the multi-stage query engine labels Feb 2, 2025
@Jackie-Jiang Jackie-Jiang force-pushed the enhance_join_operator branch from 79e007a to e584d9d Compare February 2, 2025 08:36
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 70.55215% with 48 lines in your changes missing coverage. Please review.

Project coverage is 63.65%. Comparing base (59551e4) to head (9e2f965).
Report is 1680 commits behind head on master.

Files with missing lines Patch % Lines
...query/runtime/operator/join/DoubleLookupTable.java 0.00% 12 Missing ⚠️
.../query/runtime/operator/join/FloatLookupTable.java 0.00% 12 Missing ⚠️
...t/query/runtime/operator/join/LongLookupTable.java 0.00% 12 Missing ⚠️
...pinot/query/runtime/operator/HashJoinOperator.java 87.20% 6 Missing and 5 partials ⚠️
...ot/query/runtime/operator/join/IntLookupTable.java 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14972      +/-   ##
============================================
+ Coverage     61.75%   63.65%   +1.90%     
- Complexity      207     1483    +1276     
============================================
  Files          2436     2722     +286     
  Lines        133233   152376   +19143     
  Branches      20636    23551    +2915     
============================================
+ Hits          82274    96991   +14717     
- Misses        44911    48076    +3165     
- Partials       6048     7309    +1261     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.63% <70.55%> (+1.92%) ⬆️
java-21 63.53% <70.55%> (+1.90%) ⬆️
skip-bytebuffers-false 63.65% <70.55%> (+1.90%) ⬆️
skip-bytebuffers-true 63.51% <70.55%> (+35.78%) ⬆️
temurin 63.65% <70.55%> (+1.90%) ⬆️
unittests 63.64% <70.55%> (+1.90%) ⬆️
unittests1 56.18% <70.55%> (+9.29%) ⬆️
unittests2 34.00% <0.00%> (+6.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang force-pushed the enhance_join_operator branch from e584d9d to 9e2f965 Compare February 7, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-stage Related to the multi-stage query engine performance query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants