Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases partitionGroupConsumerSemaphore incase of Errors #14974

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

noob-se7en
Copy link
Contributor

@noob-se7en noob-se7en commented Feb 3, 2025

Release partitionGroupConsumerSemaphore incase of any Errors not handled currently like OOMError.

Note: In catch block , The segment is marked as stopped consuming.
So now incase of any Error like OOM in a server, All segments will be marked as offline across all servers.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.68%. Comparing base (59551e4) to head (9f18710).
Report is 1663 commits behind head on master.

Files with missing lines Patch % Lines
...a/manager/realtime/RealtimeSegmentDataManager.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14974      +/-   ##
============================================
+ Coverage     61.75%   63.68%   +1.93%     
- Complexity      207     1482    +1275     
============================================
  Files          2436     2713     +277     
  Lines        133233   152152   +18919     
  Branches      20636    23525    +2889     
============================================
+ Hits          82274    96897   +14623     
- Misses        44911    47962    +3051     
- Partials       6048     7293    +1245     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.66% <20.00%> (+1.95%) ⬆️
java-21 63.56% <20.00%> (+1.93%) ⬆️
skip-bytebuffers-false 63.68% <20.00%> (+1.93%) ⬆️
skip-bytebuffers-true 63.54% <20.00%> (+35.81%) ⬆️
temurin 63.68% <20.00%> (+1.93%) ⬆️
unittests 63.68% <20.00%> (+1.93%) ⬆️
unittests1 56.20% <20.00%> (+9.31%) ⬆️
unittests2 34.02% <0.00%> (+6.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noob-se7en noob-se7en marked this pull request as ready for review February 3, 2025 10:57
Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@xiangfu0 xiangfu0 merged commit 891f7d1 into apache:master Feb 3, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants