[timeseries] Add Support for Passing Raw Time Values to Leaf Stage #15000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitsultana
added
the
timeseries-engine
ankitsultana
commented
Feb 5, 2025
| * timeSeriesAggregate("m3ql", "MIN", valueExpr, timeBucketExpr, firstBucketValue, bucketLenSeconds, numBuckets, | ||
| * "aggParam1=value1") | ||
| * timeSeriesAggregate("m3ql", "MIN", valueExpr, timeExpr, timeUnit, offsetSeconds, firstBucketValue, | ||
| * bucketLenSeconds, numBuckets, "aggParam1=value1") | ||
| * </pre> | ||
| */ | ||
| public TimeSeriesAggregationFunction(List<ExpressionContext> arguments) { |
There was a problem hiding this comment.
Note: At some point we'll add support for taking in another expression here, to extract the Exemplar values when appropriate.
ankitsultana
commented
Feb 6, 2025
| * The rawTimeValue is in the same Time Unit as that passed to the {@link LeafTimeSeriesPlanNode}. | ||
| * </p> | ||
| */ | ||
| public abstract void addValueAtIndex(int timeBucketIndex, Double value, long rawTimeValue); |
There was a problem hiding this comment.
self-review: by default we should fallback to the existing addValueAtIndex method and ignore the rawTimeValue.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15000 +/- ##
============================================
+ Coverage 61.75% 63.64% +1.89%
- Complexity 207 1483 +1276
============================================
Files 2436 2716 +280
Lines 133233 152237 +19004
Branches 20636 23530 +2894
============================================
+ Hits 82274 96895 +14621
- Misses 44911 48044 +3133
- Partials 6048 7298 +1250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raghavyadav01
approved these changes
Feb 6, 2025
Jackie-Jiang
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for PromQL functions. cc: @raghavyadav01