Rewrite FailureDetector interface and implementations to also work with the multi-stage engine #15005
+452
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15005 +/- ##
============================================
+ Coverage 61.75% 63.68% +1.93%
- Complexity 207 1483 +1276
============================================
Files 2436 2716 +280
Lines 133233 152298 +19065
Branches 20636 23544 +2908
============================================
+ Hits 82274 96988 +14714
- Misses 44911 48013 +3102
- Partials 6048 7297 +1249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yashmayya
commented
Feb 6, 2025
Comment on lines
+27
to
+29
| * <p> | ||
| * This class doesn't currently implement any additional logic over BaseExponentialBackoffRetryFailureDetector and is | ||
| * retained for backward compatibility. |
There was a problem hiding this comment.
On second thought we could probably remove this class altogether since the class name is not exposed via the user configuration directly.
…th the multi-stage engine
yashmayya
force-pushed
the
failure-detector-msqe
branch
from
d5ecadd to
d38daa6
Compare
yashmayya
force-pushed
the
failure-detector-msqe
branch
from
67f10b0 to
e8c1cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FailureDetectorinterface and implementations so that it works with both the engines.QueryRouter(v1) orQueryDispatcher(v2). In theFailureDetectorimplementation that retries the connection with an exponential backoff, we'll only re-add a server to the routing table if both the connections succeed - the Netty channel used for v1 queries as well as the gRPC channel used for v2 queries.FailureDetectorand listener based interface has been rewritten significantly in order to avoid multiple attempts to modify the broker routing table whenever a server is detected as healthy / unhealthy.GrpcBrokerRequestHandlerto make use of theFailureDetector.