Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor get table from tenant, so that we also get tables that have tag overwrite #15009

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

jasperjiaguo
Copy link
Contributor

refactor get table from tenant, so that we also get tables that have tag overwrite

Copy link
Contributor

@mcvsubbu mcvsubbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good to add a test with some cases of tenantconfig being null. etc.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.67%. Comparing base (59551e4) to head (b92159f).
Report is 1680 commits behind head on master.

Files with missing lines Patch % Lines
...ller/api/resources/PinotTenantRestletResource.java 0.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15009      +/-   ##
============================================
+ Coverage     61.75%   63.67%   +1.92%     
- Complexity      207     1482    +1275     
============================================
  Files          2436     2716     +280     
  Lines        133233   152267   +19034     
  Branches      20636    23540    +2904     
============================================
+ Hits          82274    96954   +14680     
- Misses        44911    48013    +3102     
- Partials       6048     7300    +1252     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.66% <0.00%> (+1.95%) ⬆️
java-21 63.55% <0.00%> (+1.92%) ⬆️
skip-bytebuffers-false 63.67% <0.00%> (+1.92%) ⬆️
skip-bytebuffers-true 63.53% <0.00%> (+35.80%) ⬆️
temurin 63.67% <0.00%> (+1.92%) ⬆️
unittests 63.66% <0.00%> (+1.92%) ⬆️
unittests1 56.20% <ø> (+9.31%) ⬆️
unittests2 34.02% <0.00%> (+6.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasperjiaguo jasperjiaguo merged commit 5fa1cf4 into apache:master Feb 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants