Skip to content

Rename polaris-quarkus-* projects as polaris-* and renaming quarkus folder as runtime #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbonofre
Copy link
Member

Quarkus is an implementation "detail", the end users should not be "bothered" by this.
I propose here to use "abstract" name in tasks (using direction polaris-* instead of polaris-quarkus-*) and rename quarkus folder as runtime.

If later we want/need to replace the runtime framework, it won't change the structure.

Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renaming proposal sounds good to me 👍

polaris-quarkus-admin=quarkus/admin
polaris-quarkus-common=quarkus/common
polaris-quarkus-test-commons=quarkus/test-commons
polaris-defaults=runtime/defaults
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular rename might be losing some context. polaris-quarkus-defaults implied defaults for the Quarkus build/runtime but polaris-defaults is too generic, I guess... How about polaris-assembly-defaults (runtime/assembly-defaults)? This modules contains some config defaults for the runtime, but more importantly some build-time defaults too (e.g. the banner), hence the term "assembly".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I like assembly name here. I will update the PR (I also have to fix the markdown links check).

@flyrain
Copy link
Contributor

flyrain commented May 28, 2025

+1 to renaming. Thanks for doing this. Just a heads-up: sweeping changes like this hit many surfaces, including “getting started” pages and instructions, that CI never sees. We’ve been burned before, PR #1532 broke plenty of things without breaking a single test in CI. So let’s do extra manual verification before we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants