-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[improve][client] Add startTimestamp
and endTimestamp
for consuming message in client cli
#24521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java
Show resolved
Hide resolved
startTimestamp
and endTimestamp
for consuming message in client cli
startTimestamp
and endTimestamp
for consuming message in client clistartTimestamp
and endTimestamp
for consuming message in client consume cli
startTimestamp
and endTimestamp
for consuming message in client consume clistartTimestamp
and endTimestamp
for consuming message in client cli
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24521 +/- ##
============================================
+ Coverage 73.57% 74.28% +0.70%
+ Complexity 32624 32535 -89
============================================
Files 1877 1869 -8
Lines 139502 146104 +6602
Branches 15299 16766 +1467
============================================
+ Hits 102638 108527 +5889
- Misses 28908 28950 +42
- Partials 7956 8627 +671
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/pulsarbot run-failure-checks |
2 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
@Technoboy- I see the |
Sure, I will send a discuss thread for this. |
Motivation
PIP-435
Add
startTimestamp
andendTimestamp
for consuming message in client consume cli.Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: