Skip to content

[improve][client] Add startTimestamp and endTimestamp for consuming message in client cli #24521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Jul 16, 2025

Motivation

PIP-435

Add startTimestamp and endTimestamp for consuming message in client consume cli.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@Technoboy- Technoboy- self-assigned this Jul 16, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 16, 2025
@Technoboy- Technoboy- added ready-to-test and removed doc-not-needed Your PR changes do not impact docs labels Jul 16, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 16, 2025
@Technoboy- Technoboy- closed this Jul 16, 2025
@Technoboy- Technoboy- reopened this Jul 16, 2025
@Technoboy- Technoboy- changed the title [improve][client] Add startTimestamp and endTimestamp for consume message from client cli [improve][client] Add startTimestamp and endTimestamp for consuming message from client cli Jul 16, 2025
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Technoboy- Technoboy- changed the title [improve][client] Add startTimestamp and endTimestamp for consuming message from client cli [improve][client] Add startTimestamp and endTimestamp for consuming message in client cli Jul 16, 2025
@Technoboy- Technoboy- changed the title [improve][client] Add startTimestamp and endTimestamp for consuming message in client cli [improve][client] Add startTimestamp and endTimestamp for consuming message in client consume cli Jul 16, 2025
@Technoboy- Technoboy- changed the title [improve][client] Add startTimestamp and endTimestamp for consuming message in client consume cli [improve][client] Add startTimestamp and endTimestamp for consuming message in client cli Jul 16, 2025
@Technoboy- Technoboy- closed this Jul 21, 2025
@Technoboy- Technoboy- reopened this Jul 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (bbc6224) to head (ce8c6ad).
Report is 1211 commits behind head on master.

Files with missing lines Patch % Lines
.../java/org/apache/pulsar/client/cli/CmdConsume.java 18.18% 4 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24521      +/-   ##
============================================
+ Coverage     73.57%   74.28%   +0.70%     
+ Complexity    32624    32535      -89     
============================================
  Files          1877     1869       -8     
  Lines        139502   146104    +6602     
  Branches      15299    16766    +1467     
============================================
+ Hits         102638   108527    +5889     
- Misses        28908    28950      +42     
- Partials       7956     8627     +671     
Flag Coverage Δ
inttests 26.76% <18.18%> (+2.18%) ⬆️
systests 23.28% <0.00%> (-1.04%) ⬇️
unittests 73.77% <18.18%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../java/org/apache/pulsar/client/cli/CmdConsume.java 40.54% <18.18%> (-0.77%) ⬇️

... and 1100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy-
Copy link
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@Technoboy-
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy-
Copy link
Contributor Author

/pulsarbot run-failure-checks

@BewareMyPower
Copy link
Contributor

@Technoboy- I see the release/4.0.6 label is added. But this is a new feature, we need to discuss if it's acceptable to cherry-pick to release branches.

@Technoboy- Technoboy- added this to the 4.1.0 milestone Jul 22, 2025
@Technoboy-
Copy link
Contributor Author

@Technoboy- I see the release/4.0.6 label is added. But this is a new feature, we need to discuss if it's acceptable to cherry-pick to release branches.

Sure, I will send a discuss thread for this.

@Technoboy- Technoboy- merged commit e627c2c into apache:master Jul 22, 2025
186 of 192 checks passed
lhotari pushed a commit that referenced this pull request Jul 22, 2025
…ng message in client cli (#24521)

(cherry picked from commit e627c2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants