Skip to content

[improve][broker] PIP-429: Optimize Handling of Compacted Last Entry by Skipping Payload Buffer Parsing #24523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BewareMyPower
Copy link
Contributor

PIP: #24439

Verifying this change

The functionality is covered by existing tests. testGetLastMessageIdForEncryptedMessage is added to verify that getLastMessageId still works when encryption is enabled. It does not work without introducing the compacted_batch_indexes field to MessageMetadata because the broker side does not know how to deserialize the SingleMessageMetadata.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: BewareMyPower#43

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jul 16, 2025
@BewareMyPower BewareMyPower self-assigned this Jul 16, 2025
@BewareMyPower BewareMyPower added this to the 4.1.0 milestone Jul 16, 2025
@BewareMyPower BewareMyPower added type/feature The PR added a new feature or issue requested a new feature type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant