RANGER-5342: USER-role users with names similar to admin or keyadmin can query those admin/keyadmin users. #697
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can query those admin/keyadmin users.
RakeshGuptaDev
force-pushed
the
RANGER-5342
branch
from
a3f2ba4 to
d8b9619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change will prevent users with the USER role from fetching details of roles other than USER.
How was this patch tested?
Built the project using: mvn clean compile package install
Validated functionality by testing the following REST APIs, which worked as expected:
curl --insecure -k -v -u 'user:pass' -H 'Accept: application/json, text/plain, /' '{hostname}:{port}/service/xusers/users?pageSize=10000&userRole=ROLE_SYS_ADMIN'
curl --insecure -k -u 'user:pass' -H 'Accept: application/json, text/plain, /' '{hostname}:{port}/service/xusers/users?pageSize=10000&userRole=ROLE_KEY_ADMIN'