fix(golang): fix data race #1109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@guyinyou @RongtongJin @lizhanhui @lizhimins Could you please review my code when you have a moment? |
Link-Tian
approved these changes
Oct 14, 2025
|
This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #1014
Brief Description
My project relies on rocketmq-clients, but because DATA RACE cannot pass the test, I submitted this PR to solve related DATA RACE issues.
I submitted a PR before to try to fix this issue, but no one did the code review. #1017
As early as 2022, I discovered the related issue, but it was not fully resolved. #294
Below is the action runs where the DATA RACE issue occurred.
https://github.com/tianping526/eventbridge/actions/runs/18458206403/job/52583549567
https://github.com/tianping526/eventbridge/actions/runs/18454601980/job/52573824963
How Did You Test This Change?
There is no DATA RACE problem in my project. https://github.com/tianping526/eventbridge/actions/runs/18460110509/job/52589414151