Skip to content

[ISSUE #9561] fix deleteUser and optimize admin for acl #9562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

1782935682
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9561

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.28571% with 36 lines in your changes missing coverage. Please review.

Project coverage is 47.95%. Comparing base (e4b731c) to head (bc64021).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/broker/processor/AdminBrokerProcessor.java 5.71% 30 Missing and 3 partials ⚠️
...ion/manager/AuthenticationMetadataManagerImpl.java 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9562      +/-   ##
=============================================
- Coverage      48.10%   47.95%   -0.16%     
+ Complexity     12063    12031      -32     
=============================================
  Files           1313     1313              
  Lines          92771    92811      +40     
  Branches       11862    11874      +12     
=============================================
- Hits           44629    44507     -122     
- Misses         42636    42776     +140     
- Partials        5506     5528      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DeleteUser in ACL2.0 should success when authorization is false
2 participants