Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates and some compiler warning cleanup in tests #135

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Feb 4, 2024

  • update project dependencies
  • selenium tests don't need an external geckodriver anymore
  • update setup-java, checkout and upload-artifact github actions
  • fixed rawtype compiler warnings in tests

- update project dependencies
- selenium tests don't need an external geckodriver anymore
- update setup-java, checkout and upload-artifact github actions
- fixed rawtype compiler warnings in tests
app/pom.xml Show resolved Hide resolved
@mbien mbien requested a review from snoopdave February 4, 2024 04:48
Copy link
Contributor

@snoopdave snoopdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the head.jsp change needed.

<script src="<s:url value='/webjars/jquery/3.6.4/jquery.min.js' />"></script>
<script src="<s:url value='/webjars/jquery/3.7.1/jquery.min.js' />"></script>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snoopdave head.jsp is already updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know how I missed that!

Merge whenver you are ready and I'll do some manual UI testing to make sure jQuery is working and my PR does not break things.

@mbien mbien merged commit 944e1f1 into apache:master Feb 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants