[type:refactor] Optimize code for shenyu-spring-boot-starter

shenyu-spring-boot-starter/shenyu-spring-boot-starter-client/shenyu-spring-boot-starter-client-common/src/main/java/org/apache/shenyu/springboot/starter/client/common/config/ShenyuClientCommonBeanConfiguration.java

@@ -73,7 +73,7 @@ public ShenyuClientConfig shenyuClientConfig() {
      * @return the shenyu discovery config
      */
     @Bean
-    @ConditionalOnProperty(prefix = "shenyu.discovery", name = "enable", matchIfMissing = false, havingValue = "true")
+    @ConditionalOnProperty(prefix = "shenyu.discovery", name = "enable", havingValue = "true")
     @ConfigurationProperties(prefix = "shenyu.discovery")
     public ShenyuDiscoveryConfig shenyuDiscoveryConfig() {
         return new ShenyuDiscoveryConfig();

shenyu-spring-boot-starter/shenyu-spring-boot-starter-client/shenyu-spring-boot-starter-client-grpc/src/main/java/org/apache/springboot/starter/client/grpc/ShenyuGrpcClientConfiguration.java

@@ -35,6 +35,7 @@
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.env.Environment;
 
+import java.util.Objects;
 import java.util.Properties;
 
 /**
@@ -64,7 +65,7 @@ public GrpcClientEventListener grpcClientEventListener(final ShenyuClientConfig
         ShenyuClientConfig.ClientPropertiesConfig clientPropertiesConfig = clientConfig.getClient().get(RpcTypeEnum.GRPC.getName());
         Properties props = clientPropertiesConfig == null ? null : clientPropertiesConfig.getProps();
         String discoveryMode = env.getProperty("shenyu.discovery.type", ShenyuClientConstants.DISCOVERY_LOCAL_MODE);
-        if (props != null) {
+        if (Objects.nonNull(props)) {
             props.setProperty(ShenyuClientConstants.DISCOVERY_LOCAL_MODE_KEY, Boolean.valueOf(ShenyuClientConstants.DISCOVERY_LOCAL_MODE.equals(discoveryMode)).toString());
         }
         return new GrpcClientEventListener(clientConfig, shenyuClientRegisterRepository);

shenyu-spring-boot-starter/shenyu-spring-boot-starter-client/shenyu-spring-boot-starter-client-springmvc/src/main/java/org/apache/shenyu/springboot/starter/client/springmvc/ShenyuSpringMvcClientConfiguration.java

@@ -17,6 +17,7 @@
 
 package org.apache.shenyu.springboot.starter.client.springmvc;
 
+import java.util.Objects;
 import java.util.Optional;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.shenyu.client.auto.config.ClientRegisterConfiguration;
@@ -70,7 +71,7 @@ public SpringMvcClientEventListener springHttpClientEventListener(final ShenyuCl
         Properties props = Optional.ofNullable(clientPropertiesConfig).map(ClientPropertiesConfig::getProps).orElse(null);
         String applicationName = env.getProperty("spring.application.name");
         String discoveryMode = env.getProperty("shenyu.discovery.type", ShenyuClientConstants.DISCOVERY_LOCAL_MODE);
-        if (props != null) {
+        if (Objects.nonNull(props)) {
             String appName = props.getProperty(ShenyuClientConstants.APP_NAME);
             if (StringUtils.isBlank(appName) && StringUtils.isBlank(applicationName)) {
                 throw new IllegalArgumentException("spring.application.name or shenyu.client.http.props.appName must not be empty");

shenyu-spring-boot-starter/shenyu-spring-boot-starter-gateway/src/main/java/org/apache/shenyu/springboot/starter/netty/ShenyuNettyWebServerConfiguration.java

@@ -19,6 +19,7 @@
 
 import io.netty.channel.ChannelOption;
 import io.netty.channel.WriteBufferWaterMark;
+import org.apache.commons.collections4.CollectionUtils;
 import org.apache.shenyu.common.config.NettyHttpProperties;
 import org.apache.shenyu.common.exception.ShenyuException;
 import org.apache.shenyu.common.config.ssl.ShenyuSniAsyncMapping;
@@ -95,16 +96,17 @@ public NettyReactiveWebServerFactory nettyReactiveWebServerFactory(final ObjectP
             NettyHttpProperties.SniProperties sniProperties = nettyHttpProperties.getSni();
             if (sniProperties.getEnabled()) {
                 ShenyuSniAsyncMapping shenyuSniAsyncMapping = shenyuSniAsyncMappingProvider.getIfAvailable();
-                if (shenyuSniAsyncMapping == null) {
+                if (Objects.isNull(shenyuSniAsyncMapping)) {
                     throw new ShenyuException("Can not find shenyuSniAsyncMapping bean");
                 }
                 if ("manual".equals(sniProperties.getMod())) {
-                    if (sniProperties.getCertificates() == null || sniProperties.getCertificates().isEmpty()) {
+                    List<SslCrtAndKeyFile> sslCrtAndKeyFiles = sniProperties.getCertificates();
+                    if (CollectionUtils.isEmpty(sslCrtAndKeyFiles)) {
                         throw new ShenyuException("At least one certificate is required");
                     }
 
                     // Use the first certificate as the default certificate (this default certificate will not actually be used)
-                    List<SslCrtAndKeyFile> certificates = sniProperties.getCertificates();
+                    List<SslCrtAndKeyFile> certificates = sslCrtAndKeyFiles;
                     for (SslCrtAndKeyFile certificate : certificates) {
                         try {
                             shenyuSniAsyncMapping.addSslCertificate(certificate);

shenyu-spring-boot-starter/shenyu-spring-boot-starter-k8s/src/main/java/org/apache/shenyu/springboot/starter/k8s/IngressControllerConfiguration.java

@@ -35,6 +35,7 @@
 import io.kubernetes.client.openapi.models.V1Service;
 import io.kubernetes.client.openapi.models.V1ServiceList;
 import io.kubernetes.client.util.generic.GenericKubernetesApi;
+import org.apache.commons.collections4.MapUtils;
 import org.apache.shenyu.common.config.NettyHttpProperties;
 import org.apache.shenyu.common.config.ssl.ShenyuSniAsyncMapping;
 import org.apache.shenyu.common.exception.ShenyuException;
@@ -55,6 +56,8 @@
 import java.io.ByteArrayInputStream;
 import java.io.InputStream;
 import java.time.Duration;
+import java.util.Map;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.concurrent.Executors;
 
@@ -96,7 +99,6 @@ public Controller ingressController(final SharedInformerFactory sharedInformerFa
                                 .build());
         // TODO support config in application.yaml
         builder.withWorkerCount(2);
-//        builder.withReadyFunc(ingressReconciler::informerReady);
         return builder.withReconciler(ingressReconciler).withName("ingressController").build();
     }
 
@@ -254,14 +256,15 @@ public SharedIndexInformer<V1Ingress> ingressInformer(final ApiClient apiClient,
     public TcpSslContextSpec tcpSslContextSpec(final ObjectProvider<NettyHttpProperties> properties, final ApiClient apiClient) throws ApiException {
         NettyHttpProperties nettyHttpProperties = Optional.ofNullable(properties.getIfAvailable()).orElse(new NettyHttpProperties());
         NettyHttpProperties.SniProperties sniProperties = nettyHttpProperties.getSni();
-        if (sniProperties != null && sniProperties.getEnabled() && "k8s".equals(sniProperties.getMod())) {
+        if (Objects.nonNull(sniProperties) && sniProperties.getEnabled() && "k8s".equals(sniProperties.getMod())) {
             String defaultName = Optional.ofNullable(sniProperties.getDefaultK8sSecretName()).orElse("default-ingress-crt");
             String defaultNamespace = Optional.ofNullable(sniProperties.getDefaultK8sSecretNamespace()).orElse("default");
             CoreV1Api coreV1Api = new CoreV1Api(apiClient);
             V1Secret secret = coreV1Api.readNamespacedSecret(defaultName, defaultNamespace, "true");
-            if (secret.getData() != null) {
-                InputStream crtStream = new ByteArrayInputStream(secret.getData().get("tls.crt"));
-                InputStream keyStream = new ByteArrayInputStream(secret.getData().get("tls.key"));
+            Map<String, byte[]> secretData = secret.getData();
+            if (MapUtils.isEmpty(secretData)) {
+                InputStream crtStream = new ByteArrayInputStream(secretData.get("tls.crt"));
+                InputStream keyStream = new ByteArrayInputStream(secretData.get("tls.key"));
                 return TcpSslContextSpec.forServer(crtStream, keyStream);
             } else {
                 throw new ShenyuException(String.format("Can not read cert and key from default secret %s/%s", defaultNamespace, defaultName));