Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add the test case for org.dromara.soul.plugin.sync.data.webosck… #588

Merged
merged 3 commits into from
Dec 7, 2020
Merged

test: add the test case for org.dromara.soul.plugin.sync.data.webosck… #588

merged 3 commits into from
Dec 7, 2020

Conversation

cocoZwwang
Copy link
Contributor

@cocoZwwang cocoZwwang commented Dec 6, 2020

…et.handler.AuthDataHandler

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

@codecov-io
Copy link

codecov-io commented Dec 6, 2020

Codecov Report

Merging #588 (3076a5f) into master (47dc629) will increase coverage by 6.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #588      +/-   ##
============================================
+ Coverage     31.65%   38.12%   +6.46%     
- Complexity      513      603      +90     
============================================
  Files           198      198              
  Lines          4669     4669              
  Branches        497      497              
============================================
+ Hits           1478     1780     +302     
+ Misses         3064     2745     -319     
- Partials        127      144      +17     
Impacted Files Coverage Δ Complexity Δ
...ava/org/dromara/soul/admin/page/PageParameter.java 82.35% <0.00%> (+5.88%) 6.00% <0.00%> (+1.00%)
...org/dromara/soul/admin/result/SoulAdminResult.java 80.00% <0.00%> (+6.66%) 8.00% <0.00%> (+1.00%)
...nc/data/weboscket/handler/AbstractDataHandler.java 8.33% <0.00%> (+8.33%) 1.00% <0.00%> (+1.00%)
...ava/org/dromara/soul/admin/vo/RuleConditionVO.java 66.66% <0.00%> (+66.66%) 1.00% <0.00%> (+1.00%)
...org/dromara/soul/admin/entity/RuleConditionDO.java 66.66% <0.00%> (+66.66%) 1.00% <0.00%> (+1.00%)
...mara/soul/admin/controller/MetaDataController.java 80.95% <0.00%> (+66.66%) 9.00% <0.00%> (+8.00%)
.../sync/data/zookeeper/ZookeeperSyncDataService.java 84.29% <0.00%> (+84.29%) 49.00% <0.00%> (+49.00%)
...omara/soul/admin/service/impl/RuleServiceImpl.java 95.12% <0.00%> (+86.58%) 17.00% <0.00%> (+16.00%)
...rc/main/java/org/dromara/soul/admin/vo/RuleVO.java 100.00% <0.00%> (+100.00%) 2.00% <0.00%> (+2.00%)
...ain/java/org/dromara/soul/admin/entity/RuleDO.java 100.00% <0.00%> (+100.00%) 4.00% <0.00%> (+4.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47dc629...3076a5f. Read the comment docs.

# Conflicts:
#	soul-sync-data-center/soul-sync-data-websocket/src/test/java/org/dromara/soul/plugin/sync/data/weboscket/handler/AuthDataHandlerTest.java
Copy link
Member

@tydhot tydhot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code annotation is cool!

@tydhot tydhot added this to the 2.3.0 milestone Dec 7, 2020
@tydhot tydhot merged commit dc6c8e9 into apache:master Dec 7, 2020
@cocoZwwang cocoZwwang deleted the issue480 branch December 7, 2020 04:31
@cocoZwwang
Copy link
Contributor Author

the code annotation is cool!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants