Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong value references in probes #23

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix wrong value references in probes #23

merged 1 commit into from
Sep 19, 2024

Conversation

kezhenxu94
Copy link
Member

No description provided.

@wu-sheng wu-sheng added this to the 0.3.0 milestone Sep 19, 2024
@wu-sheng wu-sheng added the bug Something isn't working label Sep 19, 2024
@kezhenxu94
Copy link
Member Author

@hanahmily is it intentional to set all the probes the same, especially for the startupProbe? How long averagely does it take to start for the data node?

@hanahmily
Copy link
Contributor

@hanahmily is it intentional to set all the probes the same, especially for the startupProbe? How long averagely does it take to start for the data node?

startup is different from liveness and read. Liveness and read are the same.

@hanahmily hanahmily merged commit 3cc2b41 into master Sep 19, 2024
3 checks passed
@hanahmily hanahmily deleted the probe branch September 19, 2024 03:28
@kezhenxu94
Copy link
Member Author

@hanahmily is it intentional to set all the probes the same, especially for the startupProbe? How long averagely does it take to start for the data node?

startup is different from liveness and read. Liveness and read are the same.

I thought they should be different, but they are the same:

Liveness

livenessProbe:
httpGet:
path: /api/healthz
port: 17913
{{- if .Values.standalone.tls }}
scheme: HTTPS
{{- else }}
scheme: HTTP
{{- end }}
initialDelaySeconds: {{ .Values.standalone.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.standalone.livenessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.standalone.livenessProbe.timeoutSeconds }}
successThreshold: {{ .Values.standalone.livenessProbe.successThreshold }}
failureThreshold: {{ .Values.standalone.livenessProbe.failureThreshold }}

Startup

startupProbe:
httpGet:
path: /api/healthz
port: 17913
{{- if .Values.standalone.tls }}
scheme: HTTPS
{{- else }}
scheme: HTTP
{{- end }}
initialDelaySeconds: {{ .Values.standalone.startupProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.standalone.startupProbe.periodSeconds }}
timeoutSeconds: {{ .Values.standalone.startupProbe.timeoutSeconds }}
successThreshold: {{ .Values.standalone.startupProbe.successThreshold }}
failureThreshold: {{ .Values.standalone.startupProbe.failureThreshold }}

@hanahmily
Copy link
Contributor

@hanahmily is it intentional to set all the probes the same, especially for the startupProbe? How long averagely does it take to start for the data node?

startup is different from liveness and read. Liveness and read are the same.

I thought they should be different, but they are the same:

Liveness

livenessProbe:
httpGet:
path: /api/healthz
port: 17913
{{- if .Values.standalone.tls }}
scheme: HTTPS
{{- else }}
scheme: HTTP
{{- end }}
initialDelaySeconds: {{ .Values.standalone.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.standalone.livenessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.standalone.livenessProbe.timeoutSeconds }}
successThreshold: {{ .Values.standalone.livenessProbe.successThreshold }}
failureThreshold: {{ .Values.standalone.livenessProbe.failureThreshold }}

Startup

startupProbe:
httpGet:
path: /api/healthz
port: 17913
{{- if .Values.standalone.tls }}
scheme: HTTPS
{{- else }}
scheme: HTTP
{{- end }}
initialDelaySeconds: {{ .Values.standalone.startupProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.standalone.startupProbe.periodSeconds }}
timeoutSeconds: {{ .Values.standalone.startupProbe.timeoutSeconds }}
successThreshold: {{ .Values.standalone.startupProbe.successThreshold }}
failureThreshold: {{ .Values.standalone.startupProbe.failureThreshold }}

The values at https://github.com/apache/skywalking-banyandb-helm/blob/master/chart/values.yaml#L117-L136 are different. The startup probe tends to check more frequently than liveness and readiness probes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants