Fix wrong value references in probes

[kezhenxu94]

No description provided.

[kezhenxu94]

@hanahmily is it intentional to set all the probes the same, especially for the startupProbe? How long averagely does it take to start for the data node?

[hanahmily]

@hanahmily is it intentional to set all the probes the same, especially for the startupProbe? How long averagely does it take to start for the data node?

startup is different from liveness and read. Liveness and read are the same.

[kezhenxu94]

@hanahmily is it intentional to set all the probes the same, especially for the startupProbe? How long averagely does it take to start for the data node?

startup is different from liveness and read. Liveness and read are the same.

I thought they should be different, but they are the same:

Liveness

skywalking-banyandb-helm/chart/templates/statefulset.yaml

Lines 100 to 113 in 3cc2b41

	livenessProbe:
	httpGet:
	path: /api/healthz
	port: 17913
	{{- if .Values.standalone.tls }}
	scheme: HTTPS
	{{- else }}
	scheme: HTTP
	{{- end }}
	initialDelaySeconds: {{ .Values.standalone.livenessProbe.initialDelaySeconds }}
	periodSeconds: {{ .Values.standalone.livenessProbe.periodSeconds }}
	timeoutSeconds: {{ .Values.standalone.livenessProbe.timeoutSeconds }}
	successThreshold: {{ .Values.standalone.livenessProbe.successThreshold }}
	failureThreshold: {{ .Values.standalone.livenessProbe.failureThreshold }}

Startup

skywalking-banyandb-helm/chart/templates/statefulset.yaml

Lines 114 to 127 in 3cc2b41

	startupProbe:
	httpGet:
	path: /api/healthz
	port: 17913
	{{- if .Values.standalone.tls }}
	scheme: HTTPS
	{{- else }}
	scheme: HTTP
	{{- end }}
	initialDelaySeconds: {{ .Values.standalone.startupProbe.initialDelaySeconds }}
	periodSeconds: {{ .Values.standalone.startupProbe.periodSeconds }}
	timeoutSeconds: {{ .Values.standalone.startupProbe.timeoutSeconds }}
	successThreshold: {{ .Values.standalone.startupProbe.successThreshold }}
	failureThreshold: {{ .Values.standalone.startupProbe.failureThreshold }}

[hanahmily]

@hanahmily is it intentional to set all the probes the same, especially for the startupProbe? How long averagely does it take to start for the data node?

startup is different from liveness and read. Liveness and read are the same.

I thought they should be different, but they are the same:

Liveness

skywalking-banyandb-helm/chart/templates/statefulset.yaml

Lines 100 to 113 in 3cc2b41

	livenessProbe:
	httpGet:
	path: /api/healthz
	port: 17913
	{{- if .Values.standalone.tls }}
	scheme: HTTPS
	{{- else }}
	scheme: HTTP
	{{- end }}
	initialDelaySeconds: {{ .Values.standalone.livenessProbe.initialDelaySeconds }}
	periodSeconds: {{ .Values.standalone.livenessProbe.periodSeconds }}
	timeoutSeconds: {{ .Values.standalone.livenessProbe.timeoutSeconds }}
	successThreshold: {{ .Values.standalone.livenessProbe.successThreshold }}
	failureThreshold: {{ .Values.standalone.livenessProbe.failureThreshold }}

Startup

skywalking-banyandb-helm/chart/templates/statefulset.yaml

Lines 114 to 127 in 3cc2b41

	startupProbe:
	httpGet:
	path: /api/healthz
	port: 17913
	{{- if .Values.standalone.tls }}
	scheme: HTTPS
	{{- else }}
	scheme: HTTP
	{{- end }}
	initialDelaySeconds: {{ .Values.standalone.startupProbe.initialDelaySeconds }}
	periodSeconds: {{ .Values.standalone.startupProbe.periodSeconds }}
	timeoutSeconds: {{ .Values.standalone.startupProbe.timeoutSeconds }}
	successThreshold: {{ .Values.standalone.startupProbe.successThreshold }}
	failureThreshold: {{ .Values.standalone.startupProbe.failureThreshold }}

The values at https://github.com/apache/skywalking-banyandb-helm/blob/master/chart/values.yaml#L117-L136 are different. The startup probe tends to check more frequently than liveness and readiness probes.