-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong value references in probes #23
Conversation
@hanahmily is it intentional to set all the probes the same, especially for the |
startup is different from liveness and read. Liveness and read are the same. |
I thought they should be different, but they are the same: Livenessskywalking-banyandb-helm/chart/templates/statefulset.yaml Lines 100 to 113 in 3cc2b41
Startupskywalking-banyandb-helm/chart/templates/statefulset.yaml Lines 114 to 127 in 3cc2b41
|
The values at https://github.com/apache/skywalking-banyandb-helm/blob/master/chart/values.yaml#L117-L136 are different. The startup probe tends to check more frequently than liveness and readiness probes. |
No description provided.