feature: add support to python 3.13 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
henriquemeca
changed the title
| @@ -63,7 +63,7 @@ gen-basic: | |||
| .PHONY: install | |||
| install: gen-basic | |||
| python3 -m pip install --upgrade pip | |||
| python3 -m pip install .[all] | |||
| python3 -m pip install -e .[all] | |||
There was a problem hiding this comment.
suggestion: Thinking about this parameter, maybe is not necesssary
There was a problem hiding this comment.
It adds support for editable mode, its a suggestion to improve development experience. But it's not a problem to remove it 👍
kezhenxu94
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Thanks. I didn't have time to add tests for the new version or adapt the build script for the new version. From a rough glance it requires way more changes than I expected. If you want to add, feel free to file another pull request. I will merge this since it doesn't affect previous versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration.mddocumentation by runningmake doc-genThe feature requirements where not fullfilled, but i leave this PR a suggested solution for enabling the project to work with higher python versions. Feel free to change to the code if needed.
The support for higher python versions is achieved by fixing an incompability issue with the new importlib module, changed in python version 3.12
CHANGELOG.md.