chore: move license generation to release phase #174
Conversation
|
So, from this, PR CI only checks the dependencies compatibility, but don't force the license comparison, am I understanding this correctly? |
kezhenxu94
force-pushed
the
releaselicensing
branch
from
405cd4a to
563ca43
Compare
Yes, with this PR, LICENSE file and licenses/ folder will not be compared or checked, we just make sure the licenses are compatible so we can easily generate LICENSE and licenses/ without having to revert incompatible dependencies till releasing. |
|
|
||
| 3. Generate LICENSE file in [`dist/LICENSE`](../../../../dist/LICENSE) and copy dependencies' licneses to [`dist/licenses`](../../../../dist/licenses/) folder, this can be done by running the following command in the project root: | ||
| ```shell | ||
| license-eye dep resolve --summary dist/LICENSE.tpl -o dist/licenses |
There was a problem hiding this comment.
Should we consider to locking eyes version?
I am asking this, because I want this step in oap and Java agent too.
There was a problem hiding this comment.
Added instruction to install specific version of license-eye
kezhenxu94
force-pushed
the
releaselicensing
branch
from
563ca43 to
98258d7
Compare
|
Could you apply this to oap and java agent as well? It should lower the 1st contributor bar. |
Instead of generating LICENSE in each PR, moving this to release phase can help dependencies upgrade to be more smoothly, this PR also add a GitHub Actions step to check incompatible license as early as possible, to avoid block when doing a release.