Skip to content

SLING-11485 - RepoInitValidator to check for content changes contradi… #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SLING-11485 - RepoInitValidator to check for content changes contradi… #34

wants to merge 1 commit into from

Conversation

@DominikSuess
Copy link
Contributor

@DominikSuess DominikSuess commented Jul 21, 2022

…cting repoinit

  • adjustments to RepositoryInitializer & Factory be able to execute in validation mode
  • adding validation mbean and repositoryinitializer to execute validation (mbean always in warn mode, service optionally in strict mode)

@DominikSuess
SLING-11485 - RepoInitValidator to check for content changes contradi…
5f9dd25 
…cting repoinit

* adjustments to RepositoryInitializer & Factory  be able to execute in validation mode
* adding validation mbean and repositoryinitializer to execute validation (mbean always in warn mode, service optionally in strict mode)
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

45.7% 45.7% Coverage
0.0% 0.0% Duplication

enapps-enorman
enapps-enorman requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@enapps-enorman enapps-enorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominikSuess If I am reading the changes correctly, then I believe session.save() is called a few other places that you don't seem to be handling. For example, in AclUtil#setPrincipalAcl(..), AclUtil#removePrincipalEntries(..) and AclVisitor#visitCreatePath(..)

It might be probable for regressions to appear at a future date if someone needs to call save for some other reason. Would wrapping the JCR session with an overridden save method work here and be safer?

Also, maybe refer to this as a "dry run" rather than a validator?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

44.0% 44.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

44.0% 44.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

44.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enapps-enorman enapps-enorman enapps-enorman requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DominikSuess @enapps-enorman