Skip to content

Commit

Permalink
[SPARK-50864][TESTS] Disable slow tests
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

Disables slow tests:

- `TorchDistributorDataLoaderUnitTests`
- `TorchDistributorBaselineUnitTestsOnConnect`

### Why are the changes needed?

The tests above are slow or stuck, similar to other disabled tests for [SPARK-50864](https://issues.apache.org/jira/browse/SPARK-50864).

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Run on the GHA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49664 from ueshin/gha_test.

Authored-by: Takuya UESHIN <[email protected]>
Signed-off-by: Takuya Ueshin <[email protected]>
  • Loading branch information
ueshin committed Feb 21, 2025
1 parent 42ab97a commit 1d72acc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,15 @@

from pyspark.util import is_remote_only
from pyspark.sql import SparkSession
from pyspark.testing.utils import have_torch, torch_requirement_message

if not is_remote_only():
from pyspark.ml.torch.tests.test_data_loader import TorchDistributorDataLoaderUnitTests

@unittest.skipIf(
not have_torch or is_remote_only(), torch_requirement_message or "Requires JVM access"
)
# @unittest.skipIf(
# not have_torch or is_remote_only(), torch_requirement_message or "Requires JVM access"
# )
# TODO(SPARK-50864): Re-enable this test after fixing the slowness
@unittest.skip("Disabled due to slowness")
class TorchDistributorBaselineUnitTestsOnConnect(TorchDistributorDataLoaderUnitTests):
def setUp(self) -> None:
self.spark = (
Expand Down
5 changes: 3 additions & 2 deletions python/pyspark/ml/torch/tests/test_data_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@
)
from pyspark.sql import SparkSession
from pyspark.ml.linalg import Vectors
from pyspark.testing.utils import have_torch, torch_requirement_message


@unittest.skipIf(not have_torch, torch_requirement_message)
# @unittest.skipIf(not have_torch, torch_requirement_message)
# TODO(SPARK-50864): Re-enable this test after fixing the slowness
@unittest.skip("Disabled due to slowness")
class TorchDistributorDataLoaderUnitTests(unittest.TestCase):
def setUp(self) -> None:
self.spark = (
Expand Down

0 comments on commit 1d72acc

Please sign in to comment.