Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49642][SQL] Remove the ANSI config suggestion in DATETIME_FIELD_OUT_OF_BOUNDS #49670

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −19
Draft

[SPARK-49642][SQL] Remove the ANSI config suggestion in DATETIME_FIELD_OUT_OF_BOUNDS #49670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/utils/src/main/resources/error/error-conditions.json
View file
Original file line number Diff line number Diff line change
@@ -1155,7 +1155,7 @@
},
"DATETIME_FIELD_OUT_OF_BOUNDS" : {
"message" : [
"<rangeMessage>. If necessary set <ansiConfig> to \"false\" to bypass this error."
"<rangeMessage>. To resolve this, validate your input values and ensure they fall within the acceptable range."
],
"sqlState" : "22023"
},
3 changes: 1 addition & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
View file
Original file line number Diff line number Diff line change
@@ -280,8 +280,7 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
new SparkDateTimeException(
errorClass = "DATETIME_FIELD_OUT_OF_BOUNDS",
messageParameters = Map(
"rangeMessage" -> e.getMessage,
"ansiConfig" -> toSQLConf(SQLConf.ANSI_ENABLED.key)),
"rangeMessage" -> e.getMessage),
context = Array.empty,
summary = "")
}
2 changes: 0 additions & 2 deletions sql/core/src/test/resources/sql-tests/results/date.sql.out
View file
Original file line number Diff line number Diff line change
@@ -56,7 +56,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for MonthOfYear (valid values 1 - 12): 13"
}
}
@@ -72,7 +71,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for DayOfMonth (valid values 1 - 28/31): 33"
}
}
5 changes: 0 additions & 5 deletions sql/core/src/test/resources/sql-tests/results/datetime-legacy.sql.out
View file
Original file line number Diff line number Diff line change
@@ -56,7 +56,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for MonthOfYear (valid values 1 - 12): 13"
}
}
@@ -72,7 +71,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for DayOfMonth (valid values 1 - 28/31): 33"
}
}
@@ -1347,7 +1345,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 61"
}
}
@@ -1379,7 +1376,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 99"
}
}
@@ -1395,7 +1391,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 999"
}
}
3 changes: 0 additions & 3 deletions sql/core/src/test/resources/sql-tests/results/postgreSQL/date.sql.out
View file
Original file line number Diff line number Diff line change
@@ -690,7 +690,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid date 'FEBRUARY 30'"
}
}
@@ -706,7 +705,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for MonthOfYear (valid values 1 - 12): 13"
}
}
@@ -722,7 +720,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for DayOfMonth (valid values 1 - 28/31): -1"
}
}
3 changes: 0 additions & 3 deletions sql/core/src/test/resources/sql-tests/results/timestamp.sql.out
View file
Original file line number Diff line number Diff line change
@@ -157,7 +157,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 61"
}
}
@@ -189,7 +188,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 99"
}
}
@@ -205,7 +203,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 999"
}
}
3 changes: 0 additions & 3 deletions sql/core/src/test/resources/sql-tests/results/timestampNTZ/timestamp-ansi.sql.out
View file
Original file line number Diff line number Diff line change
@@ -157,7 +157,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 61"
}
}
@@ -189,7 +188,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 99"
}
}
@@ -205,7 +203,6 @@ org.apache.spark.SparkDateTimeException
"errorClass" : "DATETIME_FIELD_OUT_OF_BOUNDS",
"sqlState" : "22023",
"messageParameters" : {
"ansiConfig" : "\"spark.sql.ansi.enabled\"",
"rangeMessage" : "Invalid value for SecondOfMinute (valid values 0 - 59): 999"
}
}