[BUILD] Upgrade RoaringBitmap to 1.3.19
#49710
Conversation
| @@ -356,6 +356,17 @@ | |||
| <enabled>false</enabled> | |||
| </snapshots> | |||
| </repository> | |||
| <repository> | |||
There was a problem hiding this comment.
The new version of RoaringBitmap requires configuring additional repositories:
-
https://github.com/RoaringBitmap/RoaringBitmap?tab=readme-ov-file#usage-within-a-maven-project
-
https://github.com/RoaringBitmap/RoaringBitmap?tab=readme-ov-file#2-using-github-packages
The second method requires additional configuration of a GitHub token, so Method One was chosen here.
LuciferYang
force-pushed
the
r-map-1.3.19
branch
from
09ffeb7 to
34d60a9
Compare
| @@ -25,7 +25,7 @@ on: | |||
| java: | |||
| required: false | |||
| type: string | |||
| default: 17 | |||
| default: 21 | |||
There was a problem hiding this comment.
will revert after test
|
Here is a discussion about republishing to Maven Central： but it seems unclear when it will be republished to Maven Central instead of just JitPack and GitHub packages. We also have the option to wait for the republish of |
| @@ -136,8 +136,8 @@ | |||
| <artifactId>tink</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.roaringbitmap</groupId> | |||
| <artifactId>RoaringBitmap</artifactId> | |||
| <groupId>com.github.RoaringBitmap.RoaringBitmap</groupId> | |||
| @@ -277,6 +277,7 @@ object SparkBuild extends PomBuild { | |||
| // Google Mirror of Maven Central, placed first so that it's used instead of flaky Maven Central. | |||
| // See https://storage-download.googleapis.com/maven-central/index.html for more info. | |||
| "gcs-maven-central-mirror" at "https://maven-central.storage-download.googleapis.com/maven2/", | |||
| "jitpack" at "https://jitpack.io", | |||
There was a problem hiding this comment.
Just wondering if this can cause a flakiness like the default Maven.
Due to the Apache Spark's high traffic, the Maven was flaky. So, we are using GCS Maven as the first cache here inevitably.
There was a problem hiding this comment.
Understand your concerns. We can wait for a while longer to see if RoaringBitmap can resume its publish on Maven Central
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?