Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51023] log remote address on RPC exception #49718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fe2s
Copy link
Contributor

@fe2s fe2s commented Jan 28, 2025

What changes were proposed in this pull request?

Add the remote address to the RPC exception log lines. It's already logged for TransportRequestHandler.processStreamRequest(), but not for other types of requests.

Why are the changes needed?

To simplify troubleshooting. We hit this in our production deployments for two cases:

  • when the executor and driver are running different Spark versions
  • when vulnerability scanner (internal security tool) sends malformed messages

Does this PR introduce any user-facing change?

No

How was this patch tested?

By verifying the logs of RpcIntegrationSuite -

25/01/28 15:06:07.439 shuffle-server-3-15 ERROR TransportRequestHandler: Error while invoking RpcHandler#receive() on RPC id 5952848813688034638 from /127.0.0.1:61697
java.lang.RuntimeException: Thrown: the
	at org.apache.spark.network.RpcIntegrationSuite$1.receive(RpcIntegrationSuite.java:73)
	at org.apache.spark.network.server.TransportRequestHandler.processRpcRequest(TransportRequestHandler.java:167)
	at org.apache.spark.network.server.TransportRequestHandler.handle(TransportRequestHandler.java:111)

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the CORE label Jan 28, 2025
@fe2s fe2s force-pushed the SPARK-51023-log_remote_address_on_RPC_exception branch from bee51f3 to e033428 Compare January 29, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant