[SPARK-51034][SQL] Reformat Describe As JSON statistics dict for parse-ability #49728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
Show resolved
Hide resolved
gengliangwang
approved these changes
Feb 3, 2025
cloud-fan
approved these changes
Feb 4, 2025
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 4, 2025
…e-ability ### What changes were proposed in this pull request? Reformat `Describe As JSON` statistics table metadata into a dict rather than string for improved parse-ability ### Why are the changes needed? Existing `Describe` formats table statistics into a string `xxx bytes, xxx rows` which is not conducive to parsing. This PR stores the table statistics metadata in raw format and delegates the formatting to the caller of toJsonLinkedHashmap, for improved parsing of the JSON statistics. ### Does this PR introduce _any_ user-facing change? Yes, it affects the output of `Describe As JSON`. ### How was this patch tested? Added to test suite `DescribeTableSuite` ### Was this patch authored or co-authored using generative AI tooling? No Closes #49728 from asl3/asl3/describetable-statistics. Authored-by: Amanda Liu <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 9d6fb58) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reformat
Describe As JSONstatistics table metadata into a dict rather than string for improved parse-abilityWhy are the changes needed?
Existing
Describeformats table statistics into a stringxxx bytes, xxx rowswhich is not conducive to parsing. This PR stores the table statistics metadata in raw format and delegates the formatting to the caller of toJsonLinkedHashmap, for improved parsing of the JSON statistics.Does this PR introduce any user-facing change?
Yes, it affects the output of
Describe As JSON.How was this patch tested?
Added to test suite
DescribeTableSuiteWas this patch authored or co-authored using generative AI tooling?
No