[SPARK-51096][SQL][TESTS] Splitting TransformWithStateSuite into UnsafeRow and Avro encoding suites #49815
+896
−811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericm-db
force-pushed
the
split-tws-suite
branch
from
b9f87ce to
6286632
Compare
ericm-db
changed the title
ericm-db
changed the title
ericm-db
force-pushed
the
split-tws-suite
branch
from
9f4b473 to
14dc48b
Compare
anishshri-db
reviewed
Feb 5, 2025
| } | ||
| } | ||
|
|
||
| test("test that introducing TTL after restart fails query") { |
There was a problem hiding this comment.
This applies to both modes right ?
There was a problem hiding this comment.
Yeah it does, but the expected error is different based on the encoding type. Couldn't find a good way to expect a different error in the test
anishshri-db
approved these changes
Feb 5, 2025
HyukjinKwon
changed the title
HeartSaVioR
reviewed
Feb 6, 2025
| @@ -1815,7 +1352,6 @@ class TransformWithStateSuite extends StateStoreMetricsTest | |||
| TransformWithStateSuiteUtils.NUM_SHUFFLE_PARTITIONS.toString) { | |||
| withTempDir { checkpointDir => | |||
| // When Avro is used, we want to set the StructFields to nullable | |||
| val shouldBeNullable = usingAvroEncoding() | |||
|
@ericm-db Looks like failure happens from refactored suite? |
|
The CI failure is not relevant - it only failed from pyspark-pandas and this PR only touched "Scala tests". |
HeartSaVioR
changed the title
|
Thanks! Merging to master/4.0. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Feb 6, 2025
…feRow and Avro encoding suites ### What changes were proposed in this pull request? Splitting the TransformWithStateSuite into TransformWithStateUnsafeRowEncodingSuite and TransformWithStateAvroEncodingSuite, in order to remove it from the slow test category ### Why are the changes needed? To remove TransformWithState-related suites from the Slow test category ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Just moving tests around, no need to test ### Was this patch authored or co-authored using generative AI tooling? No Closes #49815 from ericm-db/split-tws-suite. Authored-by: Eric Marnadi <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]> (cherry picked from commit 9dbbb5b) Signed-off-by: Jungtaek Lim <[email protected]>
zecookiez
pushed a commit
to zecookiez/spark
that referenced
this pull request
Feb 6, 2025
…feRow and Avro encoding suites ### What changes were proposed in this pull request? Splitting the TransformWithStateSuite into TransformWithStateUnsafeRowEncodingSuite and TransformWithStateAvroEncodingSuite, in order to remove it from the slow test category ### Why are the changes needed? To remove TransformWithState-related suites from the Slow test category ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Just moving tests around, no need to test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49815 from ericm-db/split-tws-suite. Authored-by: Eric Marnadi <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Splitting the TransformWithStateSuite into TransformWithStateUnsafeRowEncodingSuite and TransformWithStateAvroEncodingSuite, in order to remove it from the slow test category
Why are the changes needed?
To remove TransformWithState-related suites from the Slow test category
Does this PR introduce any user-facing change?
No
How was this patch tested?
Just moving tests around, no need to test
Was this patch authored or co-authored using generative AI tooling?
No