[SPARK-51126][PS][DOCS] Optimize the memory usage in kde examples #49842
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Feb 7, 2025
zhengruifeng
added a commit
that referenced
this pull request
Feb 7, 2025
### What changes were proposed in this pull request? Optimize the memory usage in KDE examples, the memory usage for KDE computation should be about 10% X previous value. ### Why are the changes needed? 4b7191d computes all metrics for all curves together, so only need one pass on the dataset. however, it increase the memory usage, so fail the dynamic plot generation. ### Does this PR introduce _any_ user-facing change? yes, minor quality loss before:  after:  ### How was this patch tested? manually test, with `bin/pyspark`, the example fails with OOM before ### Was this patch authored or co-authored using generative AI tooling? no Closes #49842 from zhengruifeng/ps_kde_memory_opt. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]> (cherry picked from commit 7a1dcb3) Signed-off-by: Ruifeng Zheng <[email protected]>
|
linter and doc gen passed meregd to master/4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Optimize the memory usage in KDE examples, the memory usage for KDE computation should be about 10% X previous value.
Why are the changes needed?
4b7191d computes all metrics for all curves together, so only need one pass on the dataset.
however, it increase the memory usage, so fail the dynamic plot generation.
Does this PR introduce any user-facing change?
yes, minor quality loss
before:
after:
How was this patch tested?
manually test, with
bin/pyspark, the example fails with OOM beforeWas this patch authored or co-authored using generative AI tooling?
no