[SPARK-51119][SQL][FOLLOW-UP] Fix missing fallback case for parsing corrupt exists_default value #50685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f exists_default_value
dtenedor
approved these changes
Apr 23, 2025
aokolnychyi
reviewed
Apr 23, 2025
| @@ -376,7 +376,7 @@ object ResolveDefaultColumns extends QueryErrorsBase | |||
| val expr = Literal.fromSQL(defaultSQL) match { | |||
| // EXISTS_DEFAULT will have a cast from analyze() due to coerceDefaultValue | |||
There was a problem hiding this comment.
Don't we expect the cast to be evaluated before the exists default is persisted?
There was a problem hiding this comment.
Yes in the happy path.
There are unfortunately bugs from before though, where column exists_defaults were persisted as unresolved, hence the fallback mechanism.
cloud-fan
approved these changes
Apr 24, 2025
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 24, 2025
…orrupt exists_default value ### What changes were proposed in this pull request? Add another fallback for broken (non-resolved) exists_default values for SPARK-51119 original fix. ### Why are the changes needed? #49962 added a fallback in case there were already broken (ie, non-resolved) persisted default values in catalogs. A broken one is something like 'current_database, current_user, current_timestamp' , these are non-deterministic and will bring wrong results in EXISTS_DEFAULT, where user expects the value resolved when they set the default. However, this fallback missed one case when the current_xxx is in a cast. This fixes it. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add to existing unit test in StructTypeSuite ### Was this patch authored or co-authored using generative AI tooling? No Closes #50685 from szehon-ho/SPARK-51119-follow-3. Authored-by: Szehon Ho <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 516859f) Signed-off-by: Wenchen Fan <[email protected]>
Kimahriman
pushed a commit
to Kimahriman/spark
that referenced
this pull request
May 13, 2025
…orrupt exists_default value ### What changes were proposed in this pull request? Add another fallback for broken (non-resolved) exists_default values for SPARK-51119 original fix. ### Why are the changes needed? apache#49962 added a fallback in case there were already broken (ie, non-resolved) persisted default values in catalogs. A broken one is something like 'current_database, current_user, current_timestamp' , these are non-deterministic and will bring wrong results in EXISTS_DEFAULT, where user expects the value resolved when they set the default. However, this fallback missed one case when the current_xxx is in a cast. This fixes it. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add to existing unit test in StructTypeSuite ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50685 from szehon-ho/SPARK-51119-follow-3. Authored-by: Szehon Ho <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add another fallback for broken (non-resolved) exists_default values for SPARK-51119 original fix.
Why are the changes needed?
#49962 added a fallback in case there were already broken (ie, non-resolved) persisted default values in catalogs. A broken one is something like 'current_database, current_user, current_timestamp' , these are non-deterministic and will bring wrong results in EXISTS_DEFAULT, where user expects the value resolved when they set the default.
However, this fallback missed one case when the current_xxx is in a cast. This fixes it.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add to existing unit test in StructTypeSuite
Was this patch authored or co-authored using generative AI tooling?
No