[SPARK-52560][BUILD] Bump ap-loader 4.0(v10) to support for async-profiler 4.0 #51257
Conversation
|
please also update BTW, is the async 4.0 cli interface compatible with async 3.0? |
Thank you, updated.
Comparing 3.0 arguments and 4.0 arguments, they are mostly compatible. |
|
@HyukjinKwon @dongjoon-hyun Could you please take a look? |
|
Thank you for pinging me, @wForget . |
|
cc @parthchandra , too |
|
(I haven't been able to try this PR out) but from the release notes for async-profiler, it looks like we could benefit from upgrading; among others because of improved support for JDK 23. |
|
Just a question. Did you verify this PR by running the profiling the real jobs, @wForget ? |
|
Also, cc @peter-toth |
Yes, I am currently using it to analyze some performance issues of the spark native engine (gluten) on the Spark 3.5 + JDK 1.8 + ap-loader 4.0-10 environment, like facebookincubator/velox#13861. |
|
Thank you for confirming, @wForget . |
### What changes were proposed in this pull request? Bump ap-loader version from 3.0-9 to 4.0-10. ### Why are the changes needed? `ap-loader` has already released v4.0-10, which release note refers to [Loader for 4.0 (v10): Heatmaps and Native memory profiling](https://github.com/jvm-profiling-tools/ap-loader/releases/tag/4.0-10). It should bump version from 3.0-9 to 4.0-10 for `JVMProfiler`. Backport apache/spark#51257. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test. Closes #3359 from SteNicholas/CELEBORN-2057. Authored-by: SteNicholas <[email protected]> Signed-off-by: mingji <[email protected]>
…filer 4.0 ### What changes were proposed in this pull request? Bump ap-loader 4.0-10 ### Why are the changes needed? ap-loader 4.0 (v10) has already been released, which supports for async-profier 4.0. The release guide refers to [Loader for 4.0 (v10): Heatmaps and Native memory profiling](https://github.com/jvm-profiling-tools/ap-loader/releases/tag/4.0-10) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51257 from wForget/SPARK-52560. Authored-by: wforget <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
Bump ap-loader 4.0-10
Why are the changes needed?
ap-loader 4.0 (v10) has already been released, which supports for async-profier 4.0. The release guide refers to Loader for 4.0 (v10): Heatmaps and Native memory profiling
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No