[SPARK-52503][SQL][CONNECT][4.0] Fix drop when the input column is not existent #51348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xistent
Fix `drop` when the input column is not existent
bugfix
```
import pyspark.sql.functions as F
df1 = spark.createDataFrame([("a", "b", "c") ], schema='colA string, colB string, colC string')
df2 = spark.createDataFrame([("c", "d", "") ], schema='colC string, colD string, colE string')
df3 = df1.join(df2, df1["colC"] == df2["colC"]).withColumn("colB", F.when(df1["colB"] == "b", F.concat(df1["colB"].cast("string"), F.lit("_newValue"))).otherwise(df1["colB"]))
df3
DataFrame[colA: string, colB: string, colC: string, colC: string, colD: string, colE: string]
df3.drop(df1["colB"])
DataFrame[colA: string, colC: string, colC: string, colD: string, colE: string]
```
`df3` doesn't contains `df1["colB"]`, so no columns should be dropped.
yes, bug fix
added tests
no
Closes apache#51196 from zhengruifeng/fix_drop_col.
Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
HyukjinKwon
approved these changes
Jul 2, 2025
zhengruifeng
added a commit
that referenced
this pull request
Jul 3, 2025
…t existent cherry-pick #51196 to 4.0 Closes #51348 from zhengruifeng/fix_drop_col_4. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
|
merged to 4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #51196 to 4.0