[SPARK-53425][PYTHON][TESTS] Add more table argument tests for Arrow Python UDTFs #52170
+276
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonwang-db
changed the title
allisonwang-db
commented
Aug 28, 2025
Comment on lines
811
to
1637
| # TODO(SPARK-53426): Support named table argument with DataFrame API | ||
| # input_df = self.spark.range(3) # [0, 1, 2] | ||
| # result_df = NamedArgsUDTF(table_data=input_df.asTable(), multiplier=lit(5)) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you @ueshin for the fix!
There was a problem hiding this comment.
Thanks the test can pass now!
allisonwang-db
force-pushed
the
spark-53425-tbl-arg-tests
branch
from
4b03475 to
709ab71
Compare
xinrong-meng
approved these changes
Sep 12, 2025
allisonwang-db
force-pushed
the
spark-53425-tbl-arg-tests
branch
from
709ab71 to
d13c7ce
Compare
ueshin
approved these changes
Sep 22, 2025
Comment on lines
+1439
to
+1445
| result_df = self.spark.sql( | ||
| """ | ||
| SELECT * FROM partition_sum_udtf( | ||
| TABLE(partition_test_data) PARTITION BY category | ||
| ) ORDER BY partition_key | ||
| """ | ||
| ) |
There was a problem hiding this comment.
This is also potentially flaky as same as tests in the previous PR. Use terminate to be more stable?
There was a problem hiding this comment.
Thank for pointing this out. Fixed.
Comment on lines
1485
to
1492
| result_df = self.spark.sql( | ||
| """ | ||
| SELECT * FROM dept_status_count_udtf( | ||
| TABLE(SELECT * FROM employee_data) | ||
| PARTITION BY (department, status) | ||
| ) ORDER BY dept, status | ||
| """ | ||
| ) |
|
Thanks! Merging to master |
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds more tests for various table argument support for Arrow Python UDTFs.
It also exposed some existing issues that need to be fixed:
Why are the changes needed?
To improve test coverage
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
Yes