Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORM-3132] Avoid NPE in the Values Constructor #2744

Merged
merged 6 commits into from
Dec 4, 2023
Merged

[STORM-3132] Avoid NPE in the Values Constructor #2744

merged 6 commits into from
Dec 4, 2023

Conversation

kishorvpatil
Copy link
Contributor

Values construction could end up throwing NPE.

@revans2
Copy link
Contributor

revans2 commented Jun 29, 2018

So this changes a Values(null) into a Values() That is not really what I would expect. I would prefer to have Values(null) insert a null into the list. Values(null, "A") does not turn into Values("A").

@HeartSaVioR
Copy link
Contributor

+1 to @revans2.

@kishorvpatil
Copy link
Contributor Author

@revans2 @HeartSaVioR Now constructor allows null values.

@kishorvpatil
Copy link
Contributor Author

@HeartSaVioR Removed unwanted condition.

danny0405
danny0405 approved these changes Jul 14, 2018
View reviewed changes
Copy link

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rzo1 rzo1 merged commit cf2f873 into apache:master Dec 4, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethanlm Ethanlm Ethanlm approved these changes

@HeartSaVioR HeartSaVioR HeartSaVioR left review comments

@rzo1 rzo1 rzo1 approved these changes

@agresch agresch agresch approved these changes

@danny0405 danny0405 danny0405 approved these changes

Assignees
No one assigned
Labels
stale-but-worth-a-look
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kishorvpatil @revans2 @HeartSaVioR @danny0405 @agresch @rzo1 @Ethanlm