Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky tests testTopologyIsolation and testDefaultResourceAwareStrategySharedMemory #3603

Closed
wants to merge 1 commit into from

Conversation

ThugJudy
Copy link

What is the purpose of the change

The following test cases


public void testDefaultResourceAwareStrategySharedMemory(WorkerRestrictionType schedulingLimitation) {

fail due to the non-deterministic behavior of the line

as hashset does not guarantee the ordering of elements in the class object.

I found and confirmed the flaky behavior using an open-source research tool NonDex, which shuffles implementations of nondeterminism operations.

How was the change tested

The following command can be used to reproduce assertion failures and verify the fix:

mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -pl storm-server -Dtest='org.apache.storm.scheduler.resource.strategies.scheduling.TestDefaultResourceAwareStrategy#testDefaultResourceAwareStrategySharedMemory'
mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -pl storm-server -Dtest='org.apache.storm.scheduler.resource.strategies.scheduling.TestRoundRobinNodeSorterHostIsolation#testTopologyIsolation'

…lation and TestDefaultResourceAwareStrategy#testDefaultResourceAwareStrategySharedMemory
@rzo1
Copy link
Contributor

rzo1 commented Nov 24, 2023

These tests didn't fail in the last 100+ runs. Can we adjust the test cases instead of changing the set impl?

@rzo1
Copy link
Contributor

rzo1 commented Jan 25, 2024

Got no response of the opener, no flaky tests observed in the last months / weeks.

@rzo1 rzo1 closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants