chore(linting): setting no-console to error, and migrating instances to use logging

[rusackas]

SUMMARY

Use Claude Code to clean up lint warnings about this particular rule, and enforce it via error. Now it's set up so that the actual frontend code MUST use logging (which is safer, and extensible, i.e. we can hotwire it to send a copy of the message to the backend logging service, or... whatever). In tests, the opposite is true. We use console rather than logging. Also, console is allowed in the scripts folder, since those are an exception, too.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/src/utils/testUtils.ts	✅
superset-frontend/packages/superset-ui-core/src/translation/TranslatorSingleton.ts	✅
superset-frontend/src/features/datasets/AddDataset/DatasetPanel/types.ts	✅
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/state.ts	✅
superset-frontend/src/preamble.ts	✅
superset-frontend/packages/superset-ui-core/src/components/Modal/FormModal.tsx	✅
superset-frontend/src/utils/downloadAsImage.ts	✅
superset-frontend/src/explore/components/Control.tsx	✅
superset-frontend/packages/superset-ui-core/src/components/ThemeEditor/index.tsx	✅
superset-frontend/packages/superset-ui-core/src/components/CodeSyntaxHighlighter/index.tsx	✅
superset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts	✅
superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.tsx	✅
superset-frontend/packages/superset-ui-core/src/models/Registry.ts	✅
superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx	✅
superset-frontend/packages/superset-ui-core/src/query/getClientErrorObject.ts	✅
superset-frontend/src/dashboard/components/nativeFilters/utils.ts	✅
superset-frontend/.eslintrc.js	✅
superset-frontend/src/explore/components/controls/LayerConfigsControl/LayerConfigsPopoverContent.tsx	✅
superset-frontend/src/theme/ThemeController.ts	✅
superset-frontend/src/views/CRUD/hooks.ts	✅
superset-frontend/src/dashboard/actions/dashboardState.js	✅
superset-frontend/src/SqlLab/actions/sqlLab.js	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[rusackas]

Test Failure Analysis

The CI test failures are due to a pre-existing issue in the test environment setup, not
directly caused by the console → logging changes in this PR.

Root Cause

The test suite fails when modules call translation functions (t()) at the module level
during import. Specifically,
packages/superset-ui-chart-controls/src/sections/sections.tsx calls t('Time') at
module initialization, before the translation system is properly initialized in tests.

What Changed

While investigating, I made some improvements to the test setup files:

• Fixed empty data-bootstrap attribute in spec/helpers/setup.ts to use valid JSON
• These changes only affect test setup, not the production app

Recommendation

This is a broader test infrastructure issue that should be fixed separately. The console →
logging changes in this PR are valid and don't cause the test failures - they just
exposed existing fragility in how translation is initialized during tests.