Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For topology-based deliveryservices, exclude deliveryservice server assignments when querying servers by dsId #5054

Merged
merged 2 commits into from
Sep 23, 2020
Merged

For topology-based deliveryservices, exclude deliveryservice server assignments when querying servers by dsId #5054

merged 2 commits into from
Sep 23, 2020

Conversation

zrhoffman
Copy link
Member

What does this PR (Pull Request) do?

  • This PR is not related to any Issue
  • This PR excludes Servers assigned to a Delivery Service through Delivery Service Server assignments from the list of Servers returned when querying by dsId for Topology-based Delivery Services.

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run the TO API tests

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • Intended behavior does not change, documentation is unnecessary
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman zrhoffman added bug something isn't working as intended Traffic Ops related to Traffic Ops tests related to tests and/or testing infrastructure labels Sep 21, 2020
@zrhoffman zrhoffman added this to the Flexible Topologies milestone Sep 21, 2020
rawlinp
rawlinp approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests passed

@rawlinp rawlinp merged commit f03e361 into apache:master Sep 23, 2020
@rawlinp rawlinp mentioned this pull request Sep 29, 2020
Closed
@zrhoffman zrhoffman deleted the top-dsid-fix branch September 30, 2020 04:26
@zrhoffman zrhoffman removed this from the Flexible Topologies milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlinp rawlinp rawlinp approved these changes

Assignees
No one assigned
Labels
bug something isn't working as intended tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zrhoffman @rawlinp