Make directory operations methods on Directory
#11945
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahWI
force-pushed
the
refactor/extract-directory
branch
from
86dcb27 to
dee18ce
Compare
Some static functions can now take `Directory` parameters instead of `Stripe`.
JosiahWI
force-pushed
the
refactor/extract-directory
branch
from
dee18ce to
3695b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operations are working with directory data. Right now, they operate on data of type
StripeorStripeSM, but that was because those data structures contained the directory data they needed until recently. Most of the other data there is irrelevant.This PR moves those operations (see commits for the list) into the
Directorystructure to reduce the dependence on the irrelevant parts ofStripeandStripeSM.The
StripeSMsare needed in some cases for debugging, metrics, and an intriguing invocation ofStripe::dir_validfromdir_probe; theDirectorystructure will need to be adjusted to have access to a few things for those purposes, but the details of that are still a work in progress.