Skip to content

[compress] Make warning if compress plugin has cache and range-request config #11986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[compress] Make warning if compress plugin has cache and range-request config #11986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugins/compress/configuration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,11 @@ Configuration::Parse(const char *path)
// Update the defaults for the last host configuration too, if needed.
current_host_configuration->update_defaults();

// Check combination of configs
if (!current_host_configuration->cache() && current_host_configuration->range_request()) {
warning("Combination of 'cache false' and 'range-request true' might deliver corrupted content");
}

if (state != kParseStart) {
warning("the parser state indicates that data was expected when it reached the end of the file (%d)", state);
}
Expand Down